Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use same loading indicator for lp positions #11112

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: Use same loading indicator for lp positions #11112

wants to merge 1 commit into from
+7 −7

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Jan 6, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on updating the hooks related to account positions and liquidity pool details to include isLoading in the pending state calculation, providing a more accurate indication of the loading status of data.

Detailed summary

  • In useAccountV3Positions, added isLoading to the destructuring of useQuery.
  • Updated pending state to isPending || isLoading in useAccountV3Positions.
  • In useAccountStableLpDetails, added isLoading to the destructuring of useQuery.
  • Updated pending state to isPending || isLoading in useAccountStableLpDetails.
  • In useAccountV2LpDetails, changed isFetching to isPending in the destructuring of useQuery.
  • Updated pending state to isLoading || isPending in useAccountV2LpDetails.
  • Adjusted dependency array in useAccountV2LpDetails to reflect the removal of isFetching.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: b78adb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 2:32pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Jan 6, 2025 2:32pm
blog ⬜️ Ignored (Inspect) Jan 6, 2025 2:32pm
bridge ⬜️ Ignored (Inspect) Jan 6, 2025 2:32pm
games ⬜️ Ignored (Inspect) Jan 6, 2025 2:32pm
gamification ⬜️ Ignored (Inspect) Jan 6, 2025 2:32pm
uikit ⬜️ Ignored (Inspect) Jan 6, 2025 2:32pm
ton ⬜️ Skipped (Inspect) Jan 6, 2025 2:32pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChefMomota ChefMomota Awaiting requested review from ChefMomota ChefMomota is a code owner

@Chef-Yogi Chef-Yogi Awaiting requested review from Chef-Yogi Chef-Yogi is a code owner

@chefjackson chefjackson Awaiting requested review from chefjackson chefjackson is a code owner

@ChefJerry ChefJerry Awaiting requested review from ChefJerry ChefJerry is a code owner

@thechefpenguin thechefpenguin Awaiting requested review from thechefpenguin thechefpenguin is a code owner

@chef-eric chef-eric Awaiting requested review from chef-eric chef-eric is a code owner

@chef-ryan chef-ryan Awaiting requested review from chef-ryan chef-ryan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@memoyil